-
Notifications
You must be signed in to change notification settings - Fork 533
rel: 1.0.0 #2399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rel: 1.0.0 #2399
Conversation
mgxd
commented
Jan 24, 2018
- bump version #s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Minor changelog comments.
CHANGES
Outdated
Upcoming release (1.0.0) | ||
Upcoming release | ||
================ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe let's not add an "Upcoming release" entry until after the release. Just seems weird to have it in the official release docs, even if it'll show up in "latest" on the next commit.
CHANGES
Outdated
Upcoming release | ||
================ | ||
|
||
1.0.0 (January 24, 2018) | ||
======================== | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link to the milestone? https://github.com/nipy/nipype/milestone/16?closed=1
@mgxd no, I'm not working on anything additional to this right now |
Just had a look. The currently running OSX conda-forge job was submitted a week ago. So that's fun. |
@@ -9,7 +9,7 @@ Documentation | |||
:Release: |version| | |||
:Date: |today| | |||
|
|||
Previous versions: `0.13.1 <http://nipype.readthedocs.io/en/0.13.1/>`_ `0.12.1 <http://nipype.readthedocs.io/en/0.12.1/>`_ | |||
Previous versions: `0.14.0 <http://nipype.readthedocs.io/en/v0.14.0/>`_ `0.13.1 <http://nipype.readthedocs.io/en/0.13.1/>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be 0.14.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.14.1 became 1.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:) i thought we had released 0.14.1 !! now i can understand the slowness of releases.
@@ -1,6 +1,8 @@ | |||
Upcoming release (1.0.0) | |||
1.0.0 (January 24, 2018) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be 25 now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@effigies I've updated it for the official release