Skip to content

rel: 1.0.0 #2399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2018
Merged

rel: 1.0.0 #2399

merged 2 commits into from
Jan 25, 2018

Conversation

mgxd
Copy link
Member

@mgxd mgxd commented Jan 24, 2018

  • bump version #s

@mgxd
Copy link
Member Author

mgxd commented Jan 24, 2018

@satra @effigies @djarecka testing conda now - if that passes, any final additions before releasing?

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor changelog comments.

CHANGES Outdated
Upcoming release (1.0.0)
Upcoming release
================

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe let's not add an "Upcoming release" entry until after the release. Just seems weird to have it in the official release docs, even if it'll show up in "latest" on the next commit.

CHANGES Outdated
Upcoming release
================

1.0.0 (January 24, 2018)
========================

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djarecka
Copy link
Collaborator

@mgxd no, I'm not working on anything additional to this right now

@effigies
Copy link
Member

Just had a look. The currently running OSX conda-forge job was submitted a week ago.

So that's fun.

@@ -9,7 +9,7 @@ Documentation
:Release: |version|
:Date: |today|

Previous versions: `0.13.1 <http://nipype.readthedocs.io/en/0.13.1/>`_ `0.12.1 <http://nipype.readthedocs.io/en/0.12.1/>`_
Previous versions: `0.14.0 <http://nipype.readthedocs.io/en/v0.14.0/>`_ `0.13.1 <http://nipype.readthedocs.io/en/0.13.1/>`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be 0.14.1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.14.1 became 1.0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) i thought we had released 0.14.1 !! now i can understand the slowness of releases.

@mgxd mgxd merged commit 0a5948a into nipy:master Jan 25, 2018
@@ -1,6 +1,8 @@
Upcoming release (1.0.0)
1.0.0 (January 24, 2018)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 25 now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@effigies I've updated it for the official release

@effigies effigies added this to the 1.0 milestone Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants