fix: unify import paths for Nitro runtime modules #3253
+34
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we have a problem, unbuild does not add
|
pi0
reviewed
Mar 25, 2025
| @@ -58,19 +58,19 @@ export async function resolveImportsOptions(options: NitroOptions) { | |||
| function getNitroImportsPreset(): Preset[] { | |||
| return [ | |||
| { | |||
| from: "nitro/runtime/internal/app", | |||
| from: "nitro/runtime/internal", | |||
There was a problem hiding this comment.
We should be able to import them from nitro/runtime
There was a problem hiding this comment.
I will look into it, it would be nice to fix the bug in the unbuild above. I think it would be good to go through this pr after that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
wait: unjs/mkdist#272
cc: #3246 Continuation of the work here
❓ Type of change
📚 Description
📝 Checklist