Skip to content

move tests to node #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

move tests to node #985

wants to merge 3 commits into from

Conversation

GrosSacASac
Copy link
Contributor

No description provided.

@GrosSacASac GrosSacASac changed the title move to node move tests to node Apr 16, 2025
@tunnckoCore
Copy link
Member

Hey there.

I was wondering, wait since when we got this kind of tests, haha.

I'm around to publish a patch versions to v2 and v3 switching the hexoid to cuid2 (due to vulnerability report), since the cuid2 is better, faster and more secure random.

I forgot how awful tests are around. But made them pass on v3/master. The Github pipelines were failing too due to actions/cache updates and whatnot.

All these tests for the most part are just node streams stuff and callbacks, it's nightmare. We are not testing the parser that much.

I'm planning to open a clean slate v4 branch with formidable-mini and will do some tests and introduce options similar to formidable v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants