You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jun 18, 2021. It is now read-only.
@richardlau spotted a compilation failure on Node.js 4.8.3, the problem is in the code added under PR #82 (Allow Error object to be passed to node-report).
-bash-4.2$ npm install
> [email protected] install /home/users/riclau/sandbox/github/nodereport
> node-gyp rebuild
make: Entering directory `/home/users/riclau/sandbox/github/nodereport/build'
CXX(target) Release/obj.target/api/src/node_report.o
../src/node_report.cc: In function ‘void nodereport::PrintJavaScriptErrorStack(std::ostream&, v8::Isolate*, v8::MaybeLocal<v8::Value>)’:
../src/node_report.cc:1008:88: error: no matching function for call to ‘v8::Exception::CreateMessage(v8::Isolate*&, v8::Local<v8::Value>)’
Local<Message> message = v8::Exception::CreateMessage(isolate, error.ToLocalChecked());
^
../src/node_report.cc:1008:88: note: candidate is:
In file included from /home/users/riclau/.node-gyp/4.8.3/include/node/node.h:42:0,
from ../node_modules/nan/nan.h:47,
from ../src/node_report.h:4,
from ../src/node_report.cc:1:
/home/users/riclau/.node-gyp/4.8.3/include/node/v8.h:4874:25: note: static v8::Local<v8::Message> v8::Exception::CreateMessage(v8::Local<v8::Value>)
static Local<Message> CreateMessage(Local<Value> exception);
^
/home/users/riclau/.node-gyp/4.8.3/include/node/v8.h:4874:25: note: candidate expects 1 argument, 2 provided
make: *** [Release/obj.target/api/src/node_report.o] Error 1
make: Leaving directory `/home/users/riclau/sandbox/github/nodereport/build'
The text was updated successfully, but these errors were encountered:
@richardlau spotted a compilation failure on Node.js 4.8.3, the problem is in the code added under PR #82 (Allow Error object to be passed to node-report).
The text was updated successfully, but these errors were encountered: