This repository was archived by the owner on Jun 18, 2021. It is now read-only.
node_report.cc: Fix CreateMessage call #88
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a compile failure caused by using a version of v8::Exception::CreateMessage that does not exist on Node.js releases earlier than 6. On 6 and later the older version of CreateMessage is deprecated so the new version is used.
cjihrig
approved these changes
May 23, 2017
gibfahn
approved these changes
May 23, 2017
|
LGTM - landing this shortly |
rnchamberlain
pushed a commit
that referenced
this pull request
May 24, 2017
This change fixes a compile failure caused by using a version of v8::Exception::CreateMessage that does not exist on Node.js releases earlier than 6. On 6 and later the older version of CreateMessage is deprecated so the new version is used. PR-URL: #88 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Richard Chamberlain <[email protected]>
|
Landed as fd29aa1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a compile failure caused by using a version of v8::Exception::CreateMessage that does not exist on Node.js releases earlier than 6.
On 6 and later the older version of CreateMessage is deprecated so the new version is used.
I have done CI runs against Node 4, 5 and 6 with this change:
https://ci.nodejs.org/view/post-mortem/job/nodereport-continuous-integration/162/
https://ci.nodejs.org/view/post-mortem/job/nodereport-continuous-integration/163/
https://ci.nodejs.org/view/post-mortem/job/nodereport-continuous-integration/165/
(Run 164 was a run of node-report/master against Node 4 to confirm I could reproduce the problem.)
This should resolve issue #87