Skip to content

inspector: update --inspect hint text #49100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

LiviaMedeiros
Copy link
Member

Changes link hint text:

$ node --inspect -e ""
Debugger listening on ws://127.0.0.1:9229/0f2c936f-b1cd-4ac9-aab3-f63b0f33d55e
For help, see: https://nodejs.org/en/docs/inspector

This would temporarily unbreak test/internet/test-inspector-help-page.js

Refs: nodejs/nodejs.org#5624
The guide link might be gone in foreseeable future, so this hint should probably be replaced with something else.
Suggestions are very welcome.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run. labels Aug 10, 2023
@ovflowd
Copy link
Member

ovflowd commented Aug 10, 2023

I think it's better if I just keep the redirect working for now, rather than updating the source. Because we can point that redirect to anywhere.

@ovflowd
Copy link
Member

ovflowd commented Aug 10, 2023

But it is important to mention that it will be gone in the foreseeable future.

@LiviaMedeiros
Copy link
Member Author

The issue (404 link) is fixed by restoring redirect nodejs/nodejs.org#5626, thanks!

The questions that still belong here, assuming that the guide might be absent at some point, are:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants