-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
doc: update commit-queue documentation #58275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
dario-piotrowicz:dario/doc/commit-queue-stable
May 13, 2025
Merged
doc: update commit-queue documentation #58275
nodejs-github-bot
merged 1 commit into
nodejs:main
from
dario-piotrowicz:dario/doc/commit-queue-stable
May 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
de97f6f
to
7112fb9
Compare
dea0b02
to
f672e6d
Compare
update the commit-queue contributing documentation by: - removing the references of the feature being experimental - clarifying that it applies to mergeable pull requests
f672e6d
to
9978e7a
Compare
bjohansebas
approved these changes
May 11, 2025
jasnell
approved these changes
May 12, 2025
aduh95
approved these changes
May 12, 2025
UlisesGascon
approved these changes
May 12, 2025
richardlau
approved these changes
May 12, 2025
mhdawson
approved these changes
May 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mcollina
approved these changes
May 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
legendecas
approved these changes
May 13, 2025
Landed in 656bf7d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update the commit-queue contributing documentation by:
Note
I'm proposing to remove the references of the feature being experimental since it's been
implemented 5 years ago and I think that it's widely used, so I think that it can be considered
stable at this point