build,win: fix dll build #58357
Open
build,win: fix dll build #58357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanStojanovic
added
c++
|
Review requested:
|
anonrig
approved these changes
May 16, 2025
StefanStojanovic
added
the
request-ci
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58357 +/- ##
=======================================
Coverage 90.23% 90.24%
=======================================
Files 633 633
Lines 186847 186847
Branches 36685 36685
=======================================
+ Hits 168594 168612 +18
+ Misses 11041 11037 -4
+ Partials 7212 7198 -14
🚀 New features to boost your workflow:
|
legendecas
reviewed
May 20, 2025
| [[nodiscard]] auto GetBuiltinIds() const { | ||
| return std::views::keys(*source_.read()); | ||
| } | ||
| [[nodiscard]] auto GetBuiltinIds() const -> decltype(auto); |
There was a problem hiding this comment.
The function is not inlined. It should not use auto type for return value. Otherwise the type can not be deducted if this function is used without its definition.
Suggested change
| [[nodiscard]] auto GetBuiltinIds() const -> decltype(auto); | |
| [[nodiscard]] std::ranges::keys_view<std::ranges::ref_view<const BuiltinSourceMap>> GetBuiltinIds() const; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a linker error when building Node.js DLL with ClangCL by moving
BuiltinLoader::GetBuiltinIds()implementation from.hto.ccfile.This PR tries different approach from #58235 based on @joyeecheung's comment
Fixes: #58208