Skip to content

child_process: give names to ChildProcess functions #58370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

LiviaMedeiros
Copy link
Member

No description provided.

@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. labels May 17, 2025
Copy link

codecov bot commented May 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (5f841fb) to head (c9b4509).
Report is 89 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58370      +/-   ##
==========================================
+ Coverage   90.19%   90.23%   +0.03%     
==========================================
  Files         631      633       +2     
  Lines      186670   186860     +190     
  Branches    36670    36678       +8     
==========================================
+ Hits       168374   168615     +241     
+ Misses      11112    11046      -66     
- Partials     7184     7199      +15     
Files with missing lines Coverage Δ
lib/internal/child_process.js 95.06% <100.00%> (ø)

... and 55 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LiviaMedeiros LiviaMedeiros added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 18, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 18, 2025
@nodejs-github-bot
Copy link
Collaborator

@juanarbol juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label May 18, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 18, 2025
@nodejs-github-bot
Copy link
Collaborator

@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label May 19, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 19, 2025
@nodejs-github-bot
Copy link
Collaborator

@jakecastelli jakecastelli added the commit-queue Add this label to land a pull request using GitHub Actions. label May 21, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 21, 2025
@nodejs-github-bot nodejs-github-bot merged commit 8d603d5 into nodejs:main May 21, 2025
81 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 8d603d5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants