-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
perf_hooks: make the event loop display histogram disposable #58384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58384 +/- ##
==========================================
- Coverage 90.23% 90.23% -0.01%
==========================================
Files 633 633
Lines 186883 186888 +5
Branches 36695 36690 -5
==========================================
+ Hits 168632 168636 +4
- Misses 11040 11047 +7
+ Partials 7211 7205 -6
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Same note as #58385 (review): this could be split into two commits for straightforwarder porting to previous release lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise LGTM. But I'm not sure how this will be used in real world.
From a quick search (https://github.com/search?type=code&q=%3D+monitorEventLoopDelay+language%3AJavaScript+OR+language%3ATypeScript), I could not reason about which use case can be improved with using histograom = monitorEventLoopDelay()
. Usually, a histogram might be closed in a different function scope (e.g. triggered by another event).
Fairly self-explanatory, but see the test for an example.