Skip to content

http2: add diagnostics channel 'http2.server.stream.created' #58390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RaisinTen
Copy link
Member

No description provided.

@RaisinTen RaisinTen added the diagnostics_channel Issues and PRs related to diagnostics channel label May 19, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels May 19, 2025
@nodejs-github-bot
Copy link
Collaborator

Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (38757c9) to head (d5a2e25).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #58390   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files         633      633           
  Lines      186902   186916   +14     
  Branches    36696    36699    +3     
=======================================
+ Hits       168672   168691   +19     
- Misses      11026    11034    +8     
+ Partials     7204     7191   -13     
Files with missing lines Coverage Δ
lib/internal/http2/core.js 95.51% <100.00%> (+0.01%) ⬆️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diagnostics_channel Issues and PRs related to diagnostics channel http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants