-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
test: show more information in test-http2-debug upon failure #58391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Use spawnSyncAndAssert() so that the stderr is logged when it doesn't match expectations.
4057eb4
to
855d596
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58391 +/- ##
==========================================
+ Coverage 90.12% 90.24% +0.11%
==========================================
Files 629 633 +4
Lines 186628 186902 +274
Branches 36622 36692 +70
==========================================
+ Hits 168206 168663 +457
+ Misses 11216 11046 -170
+ Partials 7206 7193 -13 🚀 New features to boost your workflow:
|
So typically CI for this PR doesn't fail so we don't have the extra information to help diagnose the failures 😂. FWIW I kicked off stress runs (1000 times) for this PR and they didn't fail either: https://ci.nodejs.org/view/Stress/job/node-stress-single-test/574/ Trying again with 10000 repetitions: https://ci.nodejs.org/view/Stress/job/node-stress-single-test/575/ |
Somehow the stress test doesn't make it show up. I guess we need to wait for it to show up in the CI then.. |
Fast-track has been requested by @joyeecheung. Please 👍 to approve. |
Adding fast-track since this looks trivial enough and helps us get more information from the CI. |
(Also, if it cannot be reproduced in stress test, but can still show up in the CI, maybe it is caused by interaction with other tests, in that case moving it to sequential maybe a good enough band-aid) |
Landed in 0bbe5d3 |
Use spawnSyncAndAssert() so that the stderr is logged when it doesn't match expectations.
Refs: #58353