Skip to content

test: show more information in test-http2-debug upon failure #58391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

joyeecheung
Copy link
Member

Use spawnSyncAndAssert() so that the stderr is logged when it doesn't match expectations.

Refs: #58353

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 19, 2025
Use spawnSyncAndAssert() so that the stderr is logged when it
doesn't match expectations.
@nodejs-github-bot
Copy link
Collaborator

Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (4454d09) to head (855d596).
Report is 117 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58391      +/-   ##
==========================================
+ Coverage   90.12%   90.24%   +0.11%     
==========================================
  Files         629      633       +4     
  Lines      186628   186902     +274     
  Branches    36622    36692      +70     
==========================================
+ Hits       168206   168663     +457     
+ Misses      11216    11046     -170     
+ Partials     7206     7193      -13     

see 98 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@richardlau
Copy link
Member

Use spawnSyncAndAssert() so that the stderr is logged when it doesn't match expectations.

Refs: #58353

So typically CI for this PR doesn't fail so we don't have the extra information to help diagnose the failures 😂.

FWIW I kicked off stress runs (1000 times) for this PR and they didn't fail either: https://ci.nodejs.org/view/Stress/job/node-stress-single-test/574/

Trying again with 10000 repetitions: https://ci.nodejs.org/view/Stress/job/node-stress-single-test/575/

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 19, 2025
@joyeecheung
Copy link
Member Author

Somehow the stress test doesn't make it show up. I guess we need to wait for it to show up in the CI then..

@joyeecheung joyeecheung added the fast-track PRs that do not need to wait for 48 hours to land. label May 19, 2025
Copy link
Contributor

Fast-track has been requested by @joyeecheung. Please 👍 to approve.

@joyeecheung
Copy link
Member Author

joyeecheung commented May 19, 2025

Adding fast-track since this looks trivial enough and helps us get more information from the CI.

@joyeecheung
Copy link
Member Author

(Also, if it cannot be reproduced in stress test, but can still show up in the CI, maybe it is caused by interaction with other tests, in that case moving it to sequential maybe a good enough band-aid)

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label May 20, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 20, 2025
@nodejs-github-bot nodejs-github-bot merged commit 0bbe5d3 into nodejs:main May 20, 2025
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 0bbe5d3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants