test: close dirs in fs-opendir test

[LiviaMedeiros]

Two subtests in test-fs-opendir.js are not closing dir. Let's fix it.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.09%. Comparing base (b4c5fb4) to head (49591bc).
Report is 15 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58855      +/-   ##
==========================================
+ Coverage   90.08%   90.09%   +0.01%     
==========================================
  Files         640      640              
  Lines      188446   188446              
  Branches    36960    36963       +3     
==========================================
+ Hits       169757   169777      +20     
+ Misses      11412    11399      -13     
+ Partials     7277     7270       -7     

see 26 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67695/

[aduh95]

Shouldn't we close it in a finally – or even better, use using?

[LiviaMedeiros]

I'd just keep it aligned with the rest of the file for now, and do a larger-scale dont-land-on- refactor across test files replacing finally and success-only cleanups with using later.

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/58855
✔  Done loading data for nodejs/node/pull/58855
----------------------------------- PR info ------------------------------------
Title      test: close dirs in `fs-opendir` test (#58855)
Author     Livia Medeiros <[email protected]> (@LiviaMedeiros)
Branch     LiviaMedeiros:test-fs-opendir-close-handles -> nodejs:main
Labels     test, author ready, needs-ci
Commits    2
 - test: close dirs in `fs-opendir` test
 - squash: lint
Committers 2
 - LiviaMedeiros <[email protected]>
 - GitHub <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/58855
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/58855
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 26 Jun 2025 21:11:38 GMT
   ✔  Approvals: 2
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/58855#pullrequestreview-2967628139
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/58855#pullrequestreview-2968449945
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-06-28T06:36:30Z: https://ci.nodejs.org/job/node-test-pull-request/67695/
- Querying data for job/node-test-pull-request/67695/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 58855
From https://github.com/nodejs/node
 * branch                  refs/pull/58855/merge -> FETCH_HEAD
✔  Fetched commits as 1c2fa7ee7090..49591bc17abb
--------------------------------------------------------------------------------
Auto-merging test/parallel/test-fs-opendir.js
[main bec7fb0a62] test: close dirs in `fs-opendir` test
 Author: LiviaMedeiros <[email protected]>
 Date: Fri Jun 27 05:07:18 2025 +0800
 1 file changed, 2 insertions(+)
Auto-merging test/parallel/test-fs-opendir.js
[main c78fbf9abf] squash: lint
 Author: Livia Medeiros <[email protected]>
 Date: Fri Jun 27 05:16:15 2025 +0800
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
test: close dirs in `fs-opendir` test
PR-URL: #58855

Reviewed-By: Luigi Pinca <[email protected]>

Reviewed-By: Antoine du Hamel <[email protected]>
[detached HEAD 2e4e6ca735] test: close dirs in fs-opendir test

Author: LiviaMedeiros <[email protected]>

Date: Fri Jun 27 05:07:18 2025 +0800

1 file changed, 2 insertions(+)

Rebasing (3/4)

Rebasing (4/4)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

squash: lint
PR-URL: #58855

Reviewed-By: Luigi Pinca <[email protected]>

Reviewed-By: Antoine du Hamel <[email protected]>
[detached HEAD f21ea6ecfa] squash: lint

Author: Livia Medeiros <[email protected]>

Date: Fri Jun 27 05:16:15 2025 +0800

1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.
ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/15948276759

[nodejs-github-bot]

Landed in f0a9478