[nrf fromlist] manifest: update hal_nordic to have SAADC samples aligned to 3.12 API #2974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nika-nordic
changed the title
nika-nordic
requested review from
masz-nordic,
mstasiaknordic,
nordic-krch and
kl-cruz
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
mstasiaknordic
approved these changes
Jun 23, 2025
For a long time (since version 3.3.0) nrfx contained an incorrectly defined symbol NRF_SAADC_8BIT_SAMPLE_WIDTH that was set to 8 for nRF54L and nRF54H Series SoCs, which was probably only true for very early engineering revisions of those. Based on this, the adc_nrfx_saadc driver was incorrectly writing consecutive 8-bit samples in supplied buffers, cutting off the highest 8 bits of the results. And for sequences with multiple channels, it was even causing that the results written as 16-bit words by hardware were partially overwritten in next iteration. In nrfx 3.12.0 (see commit f46798f) this was finally corrected - the symbol is now deprecated and it is always set to 16. This commit is a follow-up to the above and removes parts of adc_nrfx_saadc that now became dead code to prevent further confusion regarding 8-bit sampling. Signed-off-by: Andrzej Głąbek <[email protected]> (cherry picked from commit 616ec7522ccee368b1f6c5c1d27ad54a999279fe)
…3.12 Update NRFX_CONFIG_API_VER_MINOR to 12, to be compatible with latest SAADC driver changes. Signed-off-by: Jakub Zymelka <[email protected]> (cherry picked from commit be8c61ab809faa793609cabe2201edd38c2c77a4)
SHIM Nordic modification for the ADC driver controlling the SAADC peripheral. Replaced HAL based implementation in favor of nrfx driver. As a next step, it is planned to implement a feature that will allow the peripheral SAADC timer to be used for sampling, and for this it is necessary to use the nrfx driver in this SHIM. This will allow more accurate and faster sampling than the kernel mechanism currently provides. Signed-off-by: Jakub Zymelka <[email protected]> (cherry picked from commit f3d250742377ac24af0bc4bf78dd61afaefc2479)
…n on nRF54x Add sample variant to run code in 8-bit resolution on nRF54x series. Signed-off-by: Jakub Zymelka <[email protected]> (cherry picked from commit 7c14d7e6c672f20239cb3fc575874506cb18d33a)
…ned to 3.12 API NRFX_SAADC_SAMPLE_GET() macro takes two arguments now instead of three. Upstream PR #: 92020 Signed-off-by: Nikodem Kastelik <[email protected]>
nika-nordic
force-pushed
the
fix_saadc_nrfx_samples_sdkzephyr
branch
from
f2d32aa to
addc269
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NRFX_SAADC_SAMPLE_GET() macro takes two arguments now instead of three.
Upstream PR #: 92020
Link: zephyrproject-rtos/zephyr#92020