net: Cherry pick net_mgmt API changes #2990
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 26, 2025
jukkar
approved these changes
Jun 26, 2025
rlubos
changed the title
Instead of using 32 bit enum values for event numbers, convert the code to use 64 bit long bit fields. This means that the user API is changed to use 64 bit event values instead of 32 bit event values. Signed-off-by: Jukka Rissanen <[email protected]> (cherry picked from commit 5a9a39caf3bf5195a38194bb844a428eaa7f2bb8) Signed-off-by: Robert Lubos <[email protected]>
…t_mgmt sockets We cannot use the network management event number directly as a socket option value because the management value is uint64_t and that cannot be mapped directly to 32 bit integer. So have an intermediate socket option that is mapped to actual network management request number in getsockopt() and setsockopt(). Signed-off-by: Jukka Rissanen <[email protected]> (cherry picked from commit 2ed2232f17f732bcf8b21db70e6dfb4e49782be1) Signed-off-by: Robert Lubos <[email protected]>
…I changes Add information how the net_mgmt request handler is changed. The event number type is changed from uint32_t to uint64_t to allow the event command to be a bit mask instead of enum value. Signed-off-by: Jukka Rissanen <[email protected]> (cherry picked from commit 6b0597f631338b2193a57c91a1093b0aeb8dd1d2) Signed-off-by: Robert Lubos <[email protected]>
As per API overview documentation, a braking API change must increment major version number. https://docs.zephyrproject.org/latest/develop/api/overview.html#api-overview Signed-off-by: Jukka Rissanen <[email protected]> (cherry picked from commit b1a8655bf0d8fb64ce1034e7b7efd2e983360874) Signed-off-by: Robert Lubos <[email protected]>
This has been missed in net_mgmt rework in commit 5a9a39caf3bf5195a38194bb844a428eaa7f2bb8. Signed-off-by: Robert Lubos <[email protected]> (cherry picked from commit 3e704256e308fed36dfea82b1e897439eecc49fe)
net_event.h header makes use of macros defined in net_mgmt.h, therefore it should include that header. Upstream PR #: 92246 Signed-off-by: Robert Lubos <[email protected]>
rlubos
force-pushed
the
ncs/cherry-pick-net-mgmt-api-changes
branch
from
cfa86ad to
bf5df2a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an API breaking change in net_mgmt upstream, cherry-pick the change to align NCS codebase and catch any potential breakages early.