NEOS-1745: mariadb does not support index expressions

[nickzelei]

I started off by fixing the index query.
however more of the mysql manager tests were failing.

I got almost all of them working, but for some reason the current_timestamp comes back from the query and gets quoted during the create.

That needs to be investigated further.

There may also be other issues.

[linear]

NEOS-1745 MariaDB does not support index expressions

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
neosync-docs	⬜️ Ignored (Inspect)			Feb 20, 2025 11:56pm

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 325 lines in your changes missing coverage. Please review.

Project coverage is 22.11%. Comparing base (04899f8) to head (6470460).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...nternal/testutil/testcontainers/mariadb/mariadb.go	0.00%	219 Missing ⚠️
backend/pkg/sqlmanager/mysql/mysql-manager.go	0.00%	106 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3287      +/-   ##
==========================================
- Coverage   24.26%   22.11%   -2.15%     
==========================================
  Files         390      391       +1     
  Lines       45123    45421     +298     
==========================================
- Hits        10947    10044     -903     
- Misses      33078    34362    +1284     
+ Partials     1098     1015      -83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Benchstat Geomean Results

0.35% sec/op, -0.01% B/op, 0.00% allocs/op

Benchstat results

                                   │ main-benchmark.txt │         branch-benchmark.txt         │
                                   │       sec/op       │    sec/op      vs base               │
CleanPostgresType-4                         42.63n ± 4%   41.74n ± 108%        ~ (p=0.063 n=6)
Runner_Single-4                             7.713µ ± 5%   7.837µ ±   2%        ~ (p=0.699 n=6)
GenerateBool-4                              11.45n ± 1%   11.34n ±   2%        ~ (p=0.063 n=6)
GenerateBusinessName-4                      285.4n ± 0%   326.9n ±   5%  +14.56% (p=0.002 n=6)
GenerateCardNumber-4                        28.41n ± 1%   28.66n ±   1%        ~ (p=0.061 n=6)
GenerateCategorical-4                       104.1n ± 2%   102.4n ±   1%   -1.63% (p=0.002 n=6)
GenerateCity-4                              173.7n ± 0%   175.5n ±   2%   +1.04% (p=0.002 n=6)
GenerateCountry-4                           105.2n ± 1%   109.2n ±   1%   +3.80% (p=0.002 n=6)
GenerateEmail-4                             1.346µ ± 0%   1.343µ ±   1%        ~ (p=0.225 n=6)
GenerateFirstName-4                         203.9n ± 0%   200.9n ±   1%   -1.47% (p=0.002 n=6)
GenerateFloat64-4                           28.73n ± 1%   28.62n ±   0%   -0.40% (p=0.011 n=6)
GenerateFullAddress-4                       1.429µ ± 3%   1.446µ ±   0%        ~ (p=0.087 n=6)
GenerateFullName-4                          1.222µ ± 1%   1.226µ ±   2%   +0.37% (p=0.045 n=6)
GenerateGender-4                            41.42n ± 0%   41.70n ±   1%   +0.68% (p=0.002 n=6)
GenerateInt64-4                             28.41n ± 2%   27.89n ±   0%   -1.80% (p=0.002 n=6)
GenerateInt64PhoneNumber-4                  51.46n ± 2%   51.78n ±   2%        ~ (p=0.145 n=6)
GenerateInternationalPhoneNumber-4          175.8n ± 1%   177.6n ±  11%   +1.02% (p=0.002 n=6)
GenerateIpAddress-4                         569.3n ± 0%   562.7n ±   3%        ~ (p=0.065 n=6)
GenerateLastName-4                          187.4n ± 1%   191.4n ±   0%   +2.13% (p=0.002 n=6)
GenerateRandomString-4                      985.6n ± 1%   979.9n ±   1%        ~ (p=0.087 n=6)
GenerateSHA256Hash-4                        1.016µ ± 0%   1.011µ ±   0%   -0.59% (p=0.006 n=6)
GenerateSSN-4                               305.8n ± 1%   306.2n ±   0%        ~ (p=0.413 n=6)
GenerateState-4                             105.2n ± 2%   104.5n ±   0%   -0.67% (p=0.004 n=6)
GenerateStreetAddress-4                     204.0n ± 1%   205.2n ±   0%   +0.59% (p=0.004 n=6)
GenerateStringPhoneNumber-4                 179.3n ± 0%   174.7n ±   4%        ~ (p=0.058 n=6)
GenerateUnixTimestamp-4                     77.13n ± 1%   77.22n ±   0%        ~ (p=0.848 n=6)
GenerateUsername-4                          351.5n ± 0%   357.7n ±   3%   +1.76% (p=0.002 n=6)
GenerateUTCTimestamp-4                      104.2n ± 1%   104.0n ±   0%        ~ (p=0.288 n=6)
GenerateUUID-4                              734.0n ± 0%   740.7n ±   0%   +0.91% (p=0.002 n=6)
GenerateZipcode-4                           105.2n ± 2%   105.9n ±   0%        ~ (p=0.087 n=6)
TransformCharacterScramble-4                171.8n ± 1%   174.7n ±   1%   +1.72% (p=0.002 n=6)
TransformE164PhoneNumber-4                  180.2n ± 3%   179.2n ±   1%   -0.55% (p=0.019 n=6)
TransformEmail-4                            1.798µ ± 2%   1.800µ ±   0%        ~ (p=0.790 n=6)
TransformFirstName-4                        233.9n ± 0%   234.5n ±   1%        ~ (p=0.186 n=6)
TransformFloat64-4                          110.8n ± 4%   110.2n ±   0%        ~ (p=0.574 n=6)
TransformFullName-4                         1.235µ ± 2%   1.245µ ±   1%        ~ (p=0.065 n=6)
TransformInt64-4                            33.74n ± 1%   33.17n ±   0%   -1.70% (p=0.002 n=6)
TransformInt64PhoneNumber-4                 57.84n ± 2%   58.03n ±   0%        ~ (p=0.058 n=6)
TransformLastName-4                         191.6n ± 0%   192.1n ±   1%        ~ (p=0.409 n=6)
TransformString-4                           1.022µ ± 0%   1.027µ ±   0%        ~ (p=0.056 n=6)
TransformStringPhoneNumber-4                211.0n ± 2%   205.8n ±   1%   -2.47% (p=0.002 n=6)
TransformUuid-4                             36.54n ± 1%   36.43n ±   4%        ~ (p=0.372 n=6)
geomean                                     194.0n        194.7n          +0.35%

                                   │ main-benchmark.txt │         branch-benchmark.txt         │
                                   │        B/op        │     B/op      vs base                │
CleanPostgresType-4                        0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                          2.312Ki ± 1%     2.299Ki ± 1%       ~ (p=0.582 n=6)
GenerateBool-4                             0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                     304.0 ± 0%       304.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                       8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                      64.00 ± 0%       64.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                             160.0 ± 0%       160.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                            385.0 ± 0%       385.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                        208.0 ± 0%       208.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                          8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                      512.0 ± 0%       512.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                         418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                           16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                            7.000 ± 0%       7.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                 8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4         40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                        31.00 ± 0%       31.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                         176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                     186.0 ± 0%       186.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                       288.0 ± 0%       288.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                              46.00 ± 0%       46.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateState-4                            24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                    240.0 ± 0%       240.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                    8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                         205.0 ± 0%       205.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                     24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                             80.00 ± 0%       80.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4               40.00 ± 3%       40.00 ± 3%       ~ (p=1.000 n=6)
TransformE164PhoneNumber-4                 40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                           489.0 ± 0%       489.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                       224.0 ± 0%       224.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                         88.00 ± 0%       88.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                        418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                           8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                        176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformString-4                          202.0 ± 0%       202.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4               56.00 ± 0%       56.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                            16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                               ²                 -0.01%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                   │ main-benchmark.txt │        branch-benchmark.txt        │
                                   │     allocs/op      │ allocs/op   vs base                │
CleanPostgresType-4                        0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                            24.00 ± 0%     24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBool-4                             0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                     2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                       1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                      2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                             2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                          2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                            8.000 ± 0%     8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                        2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                          1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                      10.00 ± 0%     10.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                         6.000 ± 0%     6.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                           1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                            0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                 1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4         3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                        2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                         2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                     3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                       7.000 ± 0%     7.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                              3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateState-4                            2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                    2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                    1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                         6.000 ± 0%     6.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                     1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                             3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                          2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4               2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformE164PhoneNumber-4                 3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                           14.00 ± 0%     14.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                       3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                         3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                        6.000 ± 0%     6.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                           1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                        2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformString-4                          4.000 ± 0%     4.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4               4.000 ± 0%     4.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                            1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                               ²               +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean