Skip to content

Fix Nix build & direnv config #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 23, 2025
Merged

Fix Nix build & direnv config #70

merged 9 commits into from
May 23, 2025

Conversation

x10an14
Copy link
Contributor

@x10an14 x10an14 commented May 17, 2025

  • flake: Update inputs
  • fix(direnv): Specify shell w/shebang + use direnv stdlib + use correct syntax
  • flake: Simplify input dependencies
  • refactor(flake): Add formatter for nix + tidy up flake
  • fix(flake): Nix builds release + always specifies target triple

Description of changes

Relevant Issues

None

For when you'd want to test non-debug build binaries
@132ikl
Copy link
Member

132ikl commented May 22, 2025

thanks for making that change! could you fix clippy, and then I think we're good to go on this

@x10an14
Copy link
Contributor Author

x10an14 commented May 23, 2025

thanks for making that change! could you fix clippy, and then I think we're good to go on this

Done in fced6a0 =)

Feels like I touched a lot of code that clippy complained about that I haven't touched though...

@132ikl
Copy link
Member

132ikl commented May 23, 2025

seems like it's still complaining..? not sure why you had to make so many changes, seems like something is afoot

@x10an14
Copy link
Contributor Author

x10an14 commented May 23, 2025

Ahhh, I see what happened now.

I ran clippy w/some configured defaults, since at first I gave up getting the incantation at https://github.com/x10an14/nufmt/blob/7487a1f5731626f9296b6e2359c3bb8392f36f7d/.github/workflows/pull_request.yml#L26 to work for me locally.

I tried again with some more hand-rolling effort, and now I see that my local output matches (I didn't think to check previously, hence the big commit of unrelated clippy fixes, mea culpa) the previous runs' error(s).

@132ikl
Copy link
Member

132ikl commented May 23, 2025

could you reduce the clippy changes to just what's relevant to this PR? I'm not opposed to the clippy changes resulting from your config necessarily but it doesn't seem appropriate to put them in a PR for fixing the Nix build, especially when some of them include function signature changes

@x10an14
Copy link
Contributor Author

x10an14 commented May 23, 2025

could you reduce the clippy changes to just what's relevant to this PR? (...)

Done in 2809ce2.

Feel free to revert the revert if y'all want em after all.

@132ikl
Copy link
Member

132ikl commented May 23, 2025

thanks! let's get this merged finally 😄

@132ikl 132ikl merged commit 62fd38a into nushell:main May 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants