Skip to content

fix(types): allow color identifiers with dashes #3896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025

Conversation

noook
Copy link
Contributor

@noook noook commented Apr 14, 2025

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

When using colors with a dash in the identifier, the generated declaration file becomes invalid because an unquoted property with a dash is a not a valid key anymore.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

pkg-pr-new bot commented Apr 14, 2025

npm i https://pkg.pr.new/@nuxt/ui@3896

commit: 57457c6

@benjamincanac
Copy link
Member

Thanks @noook! It was indeed breaking the entire AppConfig types 😬

@benjamincanac benjamincanac merged commit e5a1e26 into nuxt:v3 Apr 15, 2025
6 checks passed
@noook noook deleted the fix/color-dash-in-identifier branch April 15, 2025 09:58
@benjamincanac benjamincanac added the v3 #1289 label Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants