#1172 add renderer.icons.webdev_colors default true #1175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-courtis
commented
Apr 17, 2022
| local icon, hl_group = web_devicons.get_icon(fname, extension) | ||
| if not M.config.icons.webdev_colors then | ||
| hl_group = "NvimTreeFileIcon" | ||
| end |
There was a problem hiding this comment.
This is the key change.
alex-courtis
commented
Apr 17, 2022
| -- If there are more extensions to the file, try to grab the icon for them recursively | ||
| return get_file_icon(fname, string.match(extension, "%.(.*)"), line, depth) | ||
| else | ||
| return #icon_state.icons.default > 0 and icon_state.icons.default .. icon_padding or "" |
There was a problem hiding this comment.
This has been replaced by get_file_icon_default, so that we get the hl group colour on files that do not have a web dev icon.
Closed
|
I can confirm it is working. |
kyazdani42
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1172
Allows user to ignore webdev icon colours, optionally using
NvimTreeFileIcon.An option could have been avoided by detecting :hi NvimTreeFileIcon and using that, however there is no API to do this. Executing
:hi NvimTreeFileIconvia pcall is error prone and slow. It also results in false positives as that group is cleared after rendering a non-webdev icon.Most of this is a refactor. The change is commented.