chore: sort icons alphabetically

[gegoune]

Closes #319

TODO:

• discuss formatting
• add CI validation
• adapt generate_colors.lua
• refactor generate_colors.lua

What's the consensus for changing format to single line tables like that? This makes sorting alphabetically much easier. We would probably have to find a way to enforce that formatting on CI.

[gegoune]

Unfortunately doesn't look like stylua has per file overrides.

[gegoune]

@alex-courtis I am thinking of breaking icon files into separate files holding single table only. Something like:

lua/
	nvim-web-devicons/
 		default_iconset/
			dark/
				by_filename.lua
				by_file_extension.lua
				by_operating_system.lua
				by_desktop_environment.lua
				by_window_manager.lua
			light/
				by_filename.lua
				by_file_extension.lua
				by_operating_system.lua
				by_desktop_environment.lua
				by_window_manager.lua
		other_iconset/
			light/
			dark/

Splitting to individual files would make it easier to sort programmatically.

If we decide to do something like that it best be done in another PR, keeping this one relatively small.

Edit: I just saw you did something similar in #418.

[hasecilu]

I like the new alignment , I remember Go and Rust formatters do this kind of aligments automatically, was that done with stylua or script?

[gegoune]

With nvim and mini.align. Shouldn't be too hard to automate it.

[alex-courtis]

@alex-courtis I am thinking of breaking icon files into separate files holding single table only. Something like:

Edit: I just saw you did something similar in #418.

That sounds fantastic... it's very difficult to see which table you are editing. [{ doesn't really help.

This sounds like the right time, whilst we're touching generation, subsequent PR sounds good.

418 is a proof of concept that needs a lot of work, not sure when I'll get back to it...

[alex-courtis]

I like the new alignment , I remember Go and Rust formatters do this kind of aligments automatically, was that done with stylua or script?

An alternative is emmylua, which is setup for nvim-tree to format via CLI (also CI): https://github.com/nvim-tree/nvim-tree.lua/blob/7a4ff1a516fe92a5ed6b79d7ce31ea4d8f341a72/Makefile#L19

It has align_continuous_similar_call_args which achieves what we're after.

stylua was retired in favour of emmylua, mainly to allow easier in-editor formatting via vim.lsp.buf.format()
nvim-tree/nvim-tree.lua#2932

[hasecilu]

That sounds fantastic... it's very difficult to see which table you are editing. ``

And that can make the code confused-contributor proof to prevent distracted maintainers (me) merge PR when key are on wrong table _-_

[alex-courtis]

This is fantastic, should have done this long ago:

• far more readable
• we can finally use sane text processing

[hasecilu]

nice!

[hasecilu]

Made some tests adding new extensions and it's working as expected.

[alex-courtis]

Do we need to? Looks good to me...

[gegoune]

I was referring to future PR which will separate tables into individual files at which point we won't have to iterate over multiple tables in single file any more.

[alex-courtis]

This is just fantastic:

• so much code deleted
• generating light completely is super robust - it had so many points of failure
• we've not had to add any fragile new ci/check/script mechanisms, just extended the existing patterns that we know work

We don't even have to update the doc - this handles everything for the dev and will be checked during CI.

[alex-courtis]

What sort of commit message could this be?

"icon tables normalised and formatted with one icon per line, light icons completely generated"