Skip to content

feat: add .dockerignore icon #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

feat: add .dockerignore icon #570

merged 1 commit into from
Mar 17, 2025

Conversation

A-caibird
Copy link
Contributor

add icon for .dockerignore extension

@gegoune
Copy link
Collaborator

gegoune commented Mar 17, 2025

Thanks!
Please follow https://github.com/nvim-tree/nvim-web-devicons/blob/master/CONTRIBUTING.md guide. Namely run make to generate light background icons and fix formatting.

@A-caibird
Copy link
Contributor Author

@gegoune I have already completed it.

@gegoune
Copy link
Collaborator

gegoune commented Mar 17, 2025

I see we already have support for .dockerignore file provided based on filename rather than extension:

$ rg dockerignore
lua/nvim-web-devicons/light/icons_by_filename.lua
12:  [".dockerignore"]              = { icon = "󰡨", color = "#2E5F99", cterm_color = "25",  name = "Dockerfile"              },

lua/nvim-web-devicons/default/icons_by_filename.lua
12:  [".dockerignore"]              = { icon = "󰡨", color = "#458EE6", cterm_color = "68",  name = "Dockerfile"              },

Do we need both? Which one should we keep?

@A-caibird
Copy link
Contributor Author

@gegoune yes,I think all of them are necessary.such as,dev.dockerignore and product.dockerignore

@gegoune
Copy link
Collaborator

gegoune commented Mar 17, 2025

@gegoune gegoune merged commit 4c3a584 into nvim-tree:master Mar 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants