fix: ensure icon overrides apply after refresh

[dsaenztagarro]

Resolves #572

What I did

Git diff maybe result a little bit confusing, but I only extracted apply_user_icons() from setup(), so it can be called also later during the refresh callback.

[alex-courtis]

Unwound the diff, changes are simply:

• apply_user_icons just moves the code out of setup unchanged
• set_icon changes param to user_icons_opts to disambiguate

I wasn't able to replicate the issue, however changes are applied as expected on manual refresh and autocmd.

Many thanks for your contribution!

[alex-courtis]

Thank you

[alex-courtis]

Unrelated nvim upstream addition. Not worth its own PR.

[dsaenztagarro]

@alex-courtis I've noticed you have reverted the change after being merged.. I feel confused.. can you please explain to me the reason?

The auto command that refresh the icons doesn't take care of keeping the icons overridden from the plugin setup configuration, and without that change, I won't be able to see the icons that I was expecting :(

I would appreciate a lot if you find the time for a few words, so I can see if I can bring to you the explanations or examples needed to keep up with the change.

Thanks in advance

[alex-courtis]

That was an emergency revert following a user reporting a catastrophic error: #575 (comment)

I'd be most grateful if you investigated.

[dsaenztagarro]

@alex-courtis I see! I totally understand the reasons and I completely agree with your criteria. Sure, I will review with care on the following days.