fix(#572, #575): ensure icon overrides apply after refresh #576
+46
−35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #572 (original issue)
Resolves #575 (reported bug)
What I did
I reapplied the changes from #572.
In addition, I fixed the reported bug with 37078ee.
How to reproduce the bug
I configured locally the plugin so I simulate I "require" the plugin from other plugin as dependency, but without calling "setup".
With this, when I open NeoVim I got exactly the same error reported by the user:
Explanation
Because
setup
was not called,user_icons
was not initialized properly. As result, callingapply_user_icons
from the auto command was 🧨 .