install.sh: respect git config --global clone.defaultRemoteName
#3548
+9
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jordan Harband <[email protected]>
ryan-williams
commented
Mar 13, 2025
There was a problem hiding this comment.
Thanks. I looked at install_nvm_from_git but am not sure how I should test this there. Would a GHA be a better place to test it?
Also it looks like the 2 GHAs that failed are also failing on master, so I'm assuming I can ignore those here.
|
Yes, GHA is the better place to add new tests, and yes, those v0.40.0 tests will fail forever and that's ok :-) |
|
I can make a standalone GHA that tests this, is that what you have in mind @ljharb? I looked at the existing tests a bit last month, but couldn't get oriented. |
|
It'd be best to add it inside the existing test suite |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3547
Uses
git config --global clone.defaultRemoteName, if it is set, otherwise falls back toorigin.