-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install.sh
: respect git config --global clone.defaultRemoteName
#3548
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some tests?
Co-authored-by: Jordan Harband <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I looked at install_nvm_from_git
but am not sure how I should test this there. Would a GHA be a better place to test it?
Also it looks like the 2 GHAs that failed are also failing on master
, so I'm assuming I can ignore those here.
Yes, GHA is the better place to add new tests, and yes, those v0.40.0 tests will fail forever and that's ok :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I can make a standalone GHA that tests this, is that what you have in mind @ljharb? I looked at the existing tests a bit last month, but couldn't get oriented. |
It'd be best to add it inside the existing test suite |
Fixes #3547
Uses
git config --global clone.defaultRemoteName
, if it is set, otherwise falls back toorigin
.