Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install.sh: respect git config --global clone.defaultRemoteName #3548

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ryan-williams
Copy link

Fixes #3547

Uses git config --global clone.defaultRemoteName, if it is set, otherwise falls back to origin.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some tests?

Copy link
Author

@ryan-williams ryan-williams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I looked at install_nvm_from_git but am not sure how I should test this there. Would a GHA be a better place to test it?

Also it looks like the 2 GHAs that failed are also failing on master, so I'm assuming I can ignore those here.

@ryan-williams ryan-williams requested a review from ljharb March 13, 2025 12:53
@ljharb
Copy link
Member

ljharb commented Mar 13, 2025

Yes, GHA is the better place to add new tests, and yes, those v0.40.0 tests will fail forever and that's ok :-)

Copy link

@Snapp949 Snapp949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ljharb ljharb marked this pull request as draft April 4, 2025 17:53
@ryan-williams
Copy link
Author

I can make a standalone GHA that tests this, is that what you have in mind @ljharb?

I looked at the existing tests a bit last month, but couldn't get oriented.

@ljharb
Copy link
Member

ljharb commented Apr 7, 2025

It'd be best to add it inside the existing test suite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

install.sh fails with non-default git config clone.defaultRemoteName
3 participants