Add Swift 2.2 support + Fix Swift Linter warnings #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This disables unnecessary rules like `trailing_newline`, also it disables `valid_docs` for pragmatic reasons: A lot of lines are documented but their documentation isn't complete. This option should be reverted sometime but I'm disabling it for the moment to fix all warnings and come to a clean slate. On the other hand this enables the rules `empty_count` and `missing_docs`. This helps even improve documentation although the `valid_docs` is turned off.
This commit fixes many warnings Swift Linter shows when `valid_docs` is turned on – but not all which is why it's kept in disabled mode. Also this refactors the FileSystemEvent file by splitting it up into three files. Otherwise the Swift Linter shows a warning because the files has too many files.
|
Thanks for all of the useful contributions and keeping things up to date! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Swift 2.2 deprecations warnings (improving compatibility with Swift 3) and also fixes all Swift Linter warnings by configuring it and fixing many warnings in code. See the detailed commit descriptions for additional information.