Conversation UI #81
Conversation UI #81
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nylas/components/E5PCF2u5hd8nuAqf3udEXk9gE6jM |
|
This pull request has been linked to Shortcut Story #69383: Conversation Component UI Updates. |
| </button> | ||
| {/if} | ||
| {#if headerExpanded} | ||
| {#each reply.to.splice(1, reply.to.length - 1) as contact} |
There was a problem hiding this comment.
Could you expand on what this is doing? Alternatively: set this as a variable and each over that variable, so we'd have a name like "uniqueParticipants" or something equivalent
There was a problem hiding this comment.
I'll note that I have a slight aversion to using splice in template logic -- it is mutative and sometimes prone to side-effects. I wonder if there's another way here.
There was a problem hiding this comment.
You're right I should be using slice! All I'm doing here is grabbing the rest of the reply.to array. The first entry is shown above, when the dropdown button is clicked they need to all be shown
<header class="mobile" class:expanded={headerExpanded}>
<span>to: {reply.to[0]?.email}</span> <!-- First email -->
{#if headerExpanded}
{#each reply.to.slice(1) as contact} <!-- Rest of them -->
<span>to: {contact.email}</span>
commons/src/methods/datetime.ts
Outdated
| return date | ||
| .toLocaleTimeString() | ||
| .replaceAll(/:\d{1,2} /g, "") | ||
| .replaceAll(/.m./g, "m"); |
There was a problem hiding this comment.
I think you can do
.toLocaleTimeString([], {
timeStyle: "short",
})
here
There was a problem hiding this comment.
What's the /.m replace doing?
There was a problem hiding this comment.
Ou very cool thanky ou!!
the replace gets rid of the periods
date.toLocaleTimeString([], {timeStyle: "short"})
> "11:06 a.m."
.replaceAll(/.m./g, "m");
> "11:06 am"
I'll simplyfy to
.replaceAll(/\./g, "")
| .toLocaleTimeString([], { timeStyle: "short" }) | ||
| .replaceAll(/\./g, ""); |
There was a problem hiding this comment.
Fix for above is to upgrade typescript microsoft/TypeScript#38266 (comment)
arjunkalburgi
requested review from
a team and
pooja169usp
and removed request for
a team
arjunkalburgi
force-pushed
the
ak/ch69383/conversation-ui
branch
from
a55c975 to
9420624
Compare
arjunkalburgi
force-pushed
the
ak/ch69383/conversation-ui
branch
from
0871e57 to
9420624
Compare
Todo
Readiness checklist
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.