plonk-wasm: Fix the warning until we can update #3210
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ark-ff` contains breaking changes so it might take a while to update. On the current version of Rust, we get a bunch of annoying scoping warnings that are easily fixed. I've got an open PR to `arkworks-rs/algebra` (the workspace repo) to backport there changes from `0.5.x` onto a 0.4.x branch. Hopefully they accept the PR and do a new patch release. If not, we can update the dependency.
richardpringle
force-pushed
the
supress-wasm-warning
branch
from
2b27dc4 to
4d254df
Compare
|
Link to arkworks branch: arkworks-rs/algebra#979 |
|
Even though I like the idea of removing the warning, I would be in favor of not having a fork of arkworks used in this workspace. I would prefer to postpone until it is solved upstream. |
@dannywillems, seems like the warnings are gone, I'll just close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ark-ffcontains breaking changes so it might take a while to update.On the current version of Rust, we get a bunch of annoying scoping
warnings that are easily fixed. I've got an open PR to
arkworks-rs/algebra(the workspace repo) to backport there changesfrom
0.5.xonto a 0.4.x branch. Hopefully they accept the PR and do anew patch release. If not, we can update the dependency.
The
arkworksteam doesn't currrently have a branch to support patches, but maybe they'll consider it