Skip to content

Revert "Cargo: remove config.toml defining alias" #3230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025
Merged

Conversation

richardpringle
Copy link
Contributor

I don't think the alias actually causes any problems and is convenient for local development. We just can't use the alias in the makefile

@dannywillems
Copy link
Member

I don't think the alias actually causes any problems and is convenient for local development. We just can't use the alias in the makefile

The issue was caused on the Mina side. It should be simple to solve it though.

@dannywillems dannywillems enabled auto-merge May 18, 2025 22:16
Copy link
Member

@dannywillems dannywillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Agreed it is ok if we do not change in the Makefile as Mina will keep using the Makefile.

@dannywillems dannywillems merged commit a767463 into master May 20, 2025
25 checks passed
@dannywillems dannywillems deleted the rp/fix-alias branch May 20, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants