implement a wrapper of CSS Font Loading API #1833
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't understand this. What's missing for this to work ? |
hhugo
reviewed
Jun 20, 2025
|
|
||
| method load : unit -> 'a meth | ||
|
|
||
| method ready : bool readonly_prop |
hhugo
reviewed
Jun 20, 2025
|
|
||
| method display : js_string t readonly_prop | ||
|
|
||
| method src : js_string t readonly_prop |
hhugo
reviewed
Jun 20, 2025
| method status : js_string t readonly_prop | ||
| end | ||
|
|
||
| val create_font_face : js_string t -> js_string t -> fontFaceElement t |
There was a problem hiding this comment.
Should we allow users to provide an optional descriptors as defined in https://developer.mozilla.org/en-US/docs/Web/API/FontFace/FontFace ?
|
It would help to have #2031 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR partially adds a wrapper of CSS Font Loading API
This PR includes:
css_font_load.ml(i): actual implementation of the wrapperfontstoDom_html.documentto returnFontFaceSetexamples/css_font_loadNote
Hi. This is my first PR on this repo. Let me know if anything is missing in this PR.
I didn't include a test for this feature because it seems the font loading API is not working on test codes in a straightforward manner (which may require stub or something of FontFaceSet)
Do you guys have any idea to handle this?