-
Notifications
You must be signed in to change notification settings - Fork 112
Update dependencies #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Update dependencies #137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @alireza-rafeezadeh ,left a comment before I go ahead and merge this
} | ||
dependencies { | ||
classpath 'com.android.tools.build:gradle:3.5.2' | ||
classpath 'com.android.tools.build:gradle:4.2.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to this gradle build tool plugin the android build tools sdk will also have to be updated to 30.0.2
for the build to pass ,modify its references in travis and the build.gradle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@odaridavid Alright I will fix it 👍
Codecov Report
@@ Coverage Diff @@
## develop #137 +/- ##
=============================================
- Coverage 67.83% 59.28% -8.55%
- Complexity 0 163 +163
=============================================
Files 43 44 +1
Lines 628 646 +18
Branches 110 119 +9
=============================================
- Hits 426 383 -43
- Misses 134 175 +41
- Partials 68 88 +20
Continue to review full report at Codecov.
|
e6fe369
to
6c1b0e1
Compare
Updated dependencies
Changed jacoco gradle plugin dependency due to its problem with newer versions of gradle
arturdm/jacoco-android-gradle-plugin#72
https://plugins.gradle.org/plugin/com.hiya.jacoco-android