Skip to content

[FIX] Chart: Fix flicker when copying chart as image #6103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: saas-18.3
Choose a base branch
from

Conversation

rrahir
Copy link
Collaborator

@rrahir rrahir commented Apr 14, 2025

When copying a chart as an image, we create a new div with a canvas to draw the image inside of it. However, the said div breaks the layout of the spreadsheet during its short existence span.

Task: 4725067

Description:

description of this task, what is implemented and why it is implemented that way.

Task: 4725067

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Apr 14, 2025

Pull request status dashboard

@rrahir rrahir force-pushed the master-fix-chart-copy-glitch-rar branch 2 times, most recently from 657eb06 to 8c452bb Compare April 18, 2025 17:49
When copying a chart as an image, we create a new div with a canvas
to draw the image inside of it. However, the said div breaks the layout
of the spreadsheet during its short existence span.

Task: 4725067
@rrahir rrahir force-pushed the master-fix-chart-copy-glitch-rar branch from 8c452bb to 326827e Compare April 23, 2025 13:20
@rrahir rrahir changed the base branch from master to saas-18.3 May 6, 2025 06:11
@rrahir rrahir force-pushed the master-fix-chart-copy-glitch-rar branch from 326827e to 24985fb Compare May 9, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants