Skip to content

[FIX] clipboard: fix copy-paste from Excel #6124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from

Conversation

hokolomopo
Copy link
Contributor

Description

When copying, we put some data-osheet in the clipboard to enable cross-sheet copy-paste. Somehow, somewhy, after we paste it in Excel Desktop, the data-osheet is put back in the clipboard by Excel no matter what we copy in the sheet.

This commit adds a bit of sanity check before getting the data-osheet from the clipboard content.

Task: 4730469

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

When copying, we put some `data-osheet` in the clipboard to enable
cross-sheet copy-paste. Somehow, somewhy, after we paste it in Excel
Desktop, the `data-osheet` is put back in the clipboard by Excel
no matter what we copy in the sheet.

This commit adds a bit of sanity check before getting the `data-osheet`
from the clipboard content.

Task: 4730469
@robodoo
Copy link
Collaborator

robodoo commented Apr 16, 2025

Pull request status dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants