[FIX] figure: anchor move when resizing with keepSize #6250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rrahir
reviewed
May 9, 2025
| @@ -320,6 +320,82 @@ describe("figures", () => { | |||
| expect(model.getters.getFigure(sheetId, figureId)).toMatchObject(expectedSize); | |||
| }); | |||
|
|
|||
| test.each([ | |||
There was a problem hiding this comment.
The tests seem very extensive, but they pass without the fix :/
DId you stumble upon some issues to reproduce the issue?
There was a problem hiding this comment.
Indeed this test suite was already able to pass before the fix but while creating the other test suite I figured I might as well test both behaviour (the change in offset and the change in size, which was not broken) as neither was tested (for the keepSize parameter) and adding this specific test only took me a few minutes.
Edit: It's true for the 1st test but the 2nd should fail without the fix, It didn't because the movement of the anchor was too small vs the figure size, it has been fixed and now fail without the fix
When resizing image with keepSize active, anchor is moved when it shouldn't. Task: 4755818
fdamhaut
force-pushed
the
saas-18.3-fix-figure-component-resize-keepsize-flda
branch
from
803cd53 to
fba4652
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
May 16, 2025
When resizing image with keepSize active, anchor is moved when it shouldn't. closes #6250 Task: 4755818 Signed-off-by: Rémi Rahir (rar) <[email protected]>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When resizing image with keepSize active, anchor is moved when it shouldn't.
Task: 4755818
Description:
description of this task, what is implemented and why it is implemented that way.
Task: 4755818
review checklist