[FIX] server: find_module should only return modules + improve diagnostic #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmahrouss
added
bug
mmahrouss
force-pushed
the
master-fix-find-module-mdms
branch
from
03e7996 to
2711035
Compare
fda-odoo
reviewed
Apr 25, 2025
server/src/core/import_resolver.rs
Outdated
| continue; | ||
| }; | ||
| if matches!(module_symbol.borrow().typ(), SymType::PACKAGE(PackageType::MODULE)) { | ||
| session.sync_odoo.modules.insert(name.clone(), Rc::downgrade(&module_symbol)); |
There was a problem hiding this comment.
I don't think this addition to sync_doo.modules is necessary as create_from_path is already doing it?
There was a problem hiding this comment.
it is redundant indeed
mmahrouss
force-pushed
the
master-fix-find-module-mdms
branch
from
2711035 to
dfd08f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.