Skip to content

[SYCLomatic][CMake] Refine dpct.cmake file and migration of CUDA_VERSION and set_target_properties #2792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tomflinda
Copy link
Contributor

Signed-off-by: chenwei.sun [email protected]

@tomflinda tomflinda requested a review from a team as a code owner April 17, 2025 00:49
@tomflinda tomflinda force-pushed the cmake_script_mgiration_val branch 6 times, most recently from 331192d to 4052ecc Compare April 22, 2025 00:52
@tomflinda tomflinda changed the title [SYCLomatic][CMake] Refine migration of CUDA_VERSION and set_target_properties [SYCLomatic][CMake] Refine dpct.cmake file and migration of CUDA_VERSION and set_target_properties Apr 22, 2025
@tomflinda tomflinda force-pushed the cmake_script_mgiration_val branch 2 times, most recently from ccbd2bd to f25b00d Compare April 22, 2025 02:53
Copy link
Contributor

@intwanghao intwanghao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomflinda tomflinda force-pushed the cmake_script_mgiration_val branch from 879cf50 to bba2ea2 Compare April 23, 2025 02:00
Signed-off-by: chenwei.sun <[email protected]>
…ATIBILITY_VERSION_MAJOR, COMPATIBILITY_VERSION_MINOR

according to the CUDA header file version used during migration.

Signed-off-by: chenwei.sun <[email protected]>
Signed-off-by: chenwei.sun <[email protected]>
Signed-off-by: chenwei.sun <[email protected]>
Signed-off-by: chenwei.sun <[email protected]>
@tomflinda tomflinda force-pushed the cmake_script_mgiration_val branch from bba2ea2 to 8ac611c Compare April 23, 2025 03:58
@tomflinda tomflinda force-pushed the cmake_script_mgiration_val branch from 8ac611c to 5287465 Compare April 23, 2025 10:17
"set(COMPATIBILITY_VERSION_MINOR " + Minor + ")",
};

const std::string InsertAfterLine =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too specific.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OKay

Signed-off-by: chenwei.sun <[email protected]>
@zhimingwang36 zhimingwang36 merged commit 27f5cf0 into oneapi-src:SYCLomatic Apr 24, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants