-
Notifications
You must be signed in to change notification settings - Fork 93
[SYCLomatic][CMake] Refine dpct.cmake file and migration of CUDA_VERSION and set_target_properties #2792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zhimingwang36
merged 9 commits into
oneapi-src:SYCLomatic
from
tomflinda:cmake_script_mgiration_val
Apr 24, 2025
Merged
[SYCLomatic][CMake] Refine dpct.cmake file and migration of CUDA_VERSION and set_target_properties #2792
zhimingwang36
merged 9 commits into
oneapi-src:SYCLomatic
from
tomflinda:cmake_script_mgiration_val
Apr 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
331192d
to
4052ecc
Compare
zhiweij1
reviewed
Apr 22, 2025
zhiweij1
reviewed
Apr 22, 2025
zhiweij1
reviewed
Apr 22, 2025
ccbd2bd
to
f25b00d
Compare
zhiweij1
approved these changes
Apr 22, 2025
intwanghao
approved these changes
Apr 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
879cf50
to
bba2ea2
Compare
Signed-off-by: chenwei.sun <[email protected]>
Signed-off-by: chenwei.sun <[email protected]>
…ATIBILITY_VERSION_MAJOR, COMPATIBILITY_VERSION_MINOR according to the CUDA header file version used during migration. Signed-off-by: chenwei.sun <[email protected]>
Signed-off-by: chenwei.sun <[email protected]>
Signed-off-by: chenwei.sun <[email protected]>
Signed-off-by: chenwei.sun <[email protected]>
Signed-off-by: chenwei.sun <[email protected]>
bba2ea2
to
8ac611c
Compare
Signed-off-by: chenwei.sun <[email protected]>
8ac611c
to
5287465
Compare
clang/lib/DPCT/DPCT.cpp
Outdated
"set(COMPATIBILITY_VERSION_MINOR " + Minor + ")", | ||
}; | ||
|
||
const std::string InsertAfterLine = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OKay
Signed-off-by: chenwei.sun <[email protected]>
zhimingwang36
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: chenwei.sun [email protected]