-
Notifications
You must be signed in to change notification settings - Fork 190
[DataAvailability] Implement oneshot execution data requester #7329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataAvailability] Implement oneshot execution data requester #7329
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7329 +/- ##
==========================================
- Coverage 42.75% 41.10% -1.66%
==========================================
Files 1591 2208 +617
Lines 146192 193639 +47447
==========================================
+ Hits 62507 79588 +17081
- Misses 78345 107441 +29096
- Partials 5340 6610 +1270
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@peterargue What do you think of this approach? I'm reusing the written code from the previous requester. The test makes sure we download execution data for every block successfully. As the requester's functions are reused, it might be everything we need for now. We can add more tests after integration with the pipeline |
module/state_synchronization/requester/oneshot_execution_data_requester_test.go
Outdated
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester_test.go
Outdated
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester.go
Outdated
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester.go
Outdated
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester.go
Outdated
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester.go
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester_test.go
Outdated
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester_test.go
Outdated
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester.go
Outdated
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester.go
Outdated
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester.go
Outdated
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester.go
Show resolved
Hide resolved
@illia-malachyn could you, please, review my changes to your PR |
module/state_synchronization/requester/oneshot_execution_data_requester.go
Outdated
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester.go
Outdated
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester.go
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester.go
Outdated
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester.go
Outdated
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester.go
Outdated
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester.go
Outdated
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester.go
Outdated
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester.go
Outdated
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester_test.go
Outdated
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester_test.go
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester.go
Outdated
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester.go
Outdated
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester.go
Outdated
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester.go
Outdated
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester.go
Outdated
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester.go
Outdated
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester.go
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester_test.go
Outdated
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester_test.go
Outdated
Show resolved
Hide resolved
module/state_synchronization/requester/oneshot_execution_data_requester.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Closes #7202