Remove the simple Process in favor of ProcessBatch #39316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
requested review from
djaglowski,
andrzej-stencel and
a team
as code owners
| @@ -38,8 +38,6 @@ type Operator interface { | |||
| CanProcess() bool | |||
| // ProcessBatch processes a batch of entries from an operator. | |||
| ProcessBatch(context.Context, []*entry.Entry) error | |||
| // Process will process an entry from an operator. | |||
| Process(context.Context, *entry.Entry) error | |||
There was a problem hiding this comment.
This is a breaking change in public API of the package github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator. If we want to remove this, probably deprecating first would be good? What do you think @djaglowski?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.