Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(resourcedetectionprocessor): add apiVersion #39355

Merged
merged 1 commit into from
Apr 14, 2025
Merged

docs(resourcedetectionprocessor): add apiVersion #39355

merged 1 commit into from
Apr 14, 2025
+1 −0

Conversation

mbaykara
Copy link
Contributor

Description

Added the missing apiVersion in the Role object.

@mbaykara mbaykara requested review from dashpole and a team as code owners April 11, 2025 20:14
@github-actions github-actions bot added the processor/resourcedetection Resource detection processor label Apr 11, 2025
@github-actions github-actions bot requested a review from Aneurysm9 April 11, 2025 20:14
atoulme
atoulme approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks correct to me.

@atoulme atoulme added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 11, 2025
dehaansa
dehaansa approved these changes Apr 12, 2025
View reviewed changes
Copy link
Contributor

@dehaansa dehaansa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the docs!

@atoulme atoulme merged commit 5f736b2 into open-telemetry:main Apr 14, 2025
161 of 162 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme approved these changes

@dehaansa dehaansa dehaansa approved these changes

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

Assignees

@dehaansa dehaansa

Labels
processor/resourcedetection Resource detection processor Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
next release
Development

Successfully merging this pull request may close these issues.
3 participants
@mbaykara @atoulme @dehaansa