Skip to content

[chore] add ARM to load tests #39357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[chore] add ARM to load tests #39357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/load-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ permissions: read-all
jobs:
setup-environment:
timeout-minutes: 30
runs-on: self-hosted
runs-on: ubuntu-24.04
if: ${{ github.actor != 'dependabot[bot]' }}
outputs:
loadtest_matrix: ${{ steps.splitloadtest.outputs.loadtest_matrix }}
Expand Down Expand Up @@ -51,6 +51,7 @@ jobs:
run: make install-tools
- run: make genoteltestbedcol
- run: make oteltestbedcol
- run: GOOS=linux GOARCH=arm64 make oteltestbedcol
- name: Upload Testbed Binaries
uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 # v4
with:
Expand All @@ -61,11 +62,11 @@ jobs:
run: ./.github/workflows/scripts/setup_e2e_tests.sh

loadtest:
runs-on: self-hosted
needs: [setup-environment]
strategy:
fail-fast: false
matrix: ${{ fromJson(needs.setup-environment.outputs.loadtest_matrix) }}
runs-on: "${{ matrix.runner }}"
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
- uses: actions/setup-go@f111f3307d8850f501ac008e886eec1fd1932a34 # v5
Expand Down Expand Up @@ -98,6 +99,7 @@ jobs:
- name: Loadtest
run: make -C testbed run-tests
env:
RUN_TYPE: "${{ matrix.type == "linux-arm64" && "linux_arm64" || null }}"
TEST_ARGS: "-test.run=${{ matrix.test }}"
- name: Set results filename
if: ${{ failure() || success() }}
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/scripts/setup_e2e_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,6 @@ for i in "${!TEST_ARRAY[@]}"; do
curr="${TEST_ARRAY[$i]}"
fi
done
MATRIX+=",{\"test\":\"$curr\"}]}"
MATRIX+=",{\"test\":\"$curr\",\"runner\":\"github-benchmark-runner\",\"type\":\"linux-amd64\"}]}"
MATRIX+=",{\"test\":\"$curr\",\"runner\":\"oracle-16cpu-64gb-arm64\",\"type\":\"linux-arm64\"}]}"
echo "loadtest_matrix=$MATRIX" >> "$GITHUB_OUTPUT"
19 changes: 12 additions & 7 deletions testbed/testbed/results.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,48 +127,53 @@ func (r *PerformanceResults) Add(_ string, result any) {
memoryChartName := fmt.Sprintf("%s - RAM (MiB)", testResult.testName)
droppedSpansChartName := fmt.Sprintf("%s - Dropped Span Count", testResult.testName)

runType := ""
if t := os.Getenv("RUN_TYPE"); t != "" {
runType = fmt.Sprintf("_%s", t)
}

r.benchmarkResults = append(r.benchmarkResults, &benchmarkResult{
Name: "cpu_percentage_avg",
Name: fmt.Sprintf("cpu_percentage_avg%s", runType),
Value: testResult.cpuPercentageAvg,
Unit: "%",
Extra: cpuChartName,
})
r.benchmarkResults = append(r.benchmarkResults, &benchmarkResult{
Name: "cpu_percentage_max",
Name: fmt.Sprintf("cpu_percentage_max%s", runType),
Value: testResult.cpuPercentageMax,
Unit: "%",
Extra: cpuChartName,
})
if testResult.cpuPercentageLimit > 0 {
r.benchmarkResults = append(r.benchmarkResults, &benchmarkResult{
Name: "cpu_percentage_limit",
Name: fmt.Sprintf("cpu_percentage_limit%s", runType),
Value: testResult.cpuPercentageLimit,
Unit: "%",
Extra: cpuChartName,
})
}
r.benchmarkResults = append(r.benchmarkResults, &benchmarkResult{
Name: "ram_mib_avg",
Name: fmt.Sprintf("ram_mib_avg%s", runType),
Value: float64(testResult.ramMibAvg),
Unit: "MiB",
Extra: memoryChartName,
})
r.benchmarkResults = append(r.benchmarkResults, &benchmarkResult{
Name: "ram_mib_max",
Name: fmt.Sprintf("ram_mib_max%s", runType),
Value: float64(testResult.ramMibMax),
Unit: "MiB",
Extra: memoryChartName,
})
if testResult.ramMibLimit > 0 {
r.benchmarkResults = append(r.benchmarkResults, &benchmarkResult{
Name: "ram_mib_limit",
Name: fmt.Sprintf("ram_mib_limit%s", runType),
Value: float64(testResult.ramMibLimit),
Unit: "MiB",
Extra: memoryChartName,
})
}
r.benchmarkResults = append(r.benchmarkResults, &benchmarkResult{
Name: "dropped_span_count",
Name: fmt.Sprintf("dropped_span_count%s", runType),
Value: float64(testResult.sentSpanCount - testResult.receivedSpanCount),
Unit: "spans",
Extra: droppedSpansChartName,
Expand Down