Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Small cleanup in file reader, always count record nums #39366

Merged
merged 1 commit into from
Apr 13, 2025
Merged

[chore] Small cleanup in file reader, always count record nums #39366

merged 1 commit into from
Apr 13, 2025

Conversation

bogdandrutu
Copy link
Member

No description provided.

djaglowski
djaglowski approved these changes Apr 13, 2025
View reviewed changes
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also deprecate fileconsumer.Config.IncludeFileRecordNumber since it is always counted and emitted?

@bogdandrutu
Copy link
Member Author

It is still used

opentelemetry-collector-contrib/pkg/stanza/operator/input/file/input.go

Line 77 in 6e5c2ba

if i.includeFileRecordNumber {
, and number is not always included, it is only that we emit it to the emitFunc, but not include it.

@atoulme atoulme merged commit 228f253 into open-telemetry:main Apr 13, 2025
172 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 13, 2025
@bogdandrutu bogdandrutu deleted the small-cleanup-reader branch April 14, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme approved these changes

@djaglowski djaglowski djaglowski approved these changes

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner

Assignees

@TylerHelmuth TylerHelmuth

Labels
pkg/stanza/fileconsumer pkg/stanza
Projects
None yet
Milestone
next release
Development

Successfully merging this pull request may close these issues.
4 participants
@bogdandrutu @atoulme @djaglowski @TylerHelmuth