-
Notifications
You must be signed in to change notification settings - Fork 649
otelrestful: use semconv package for request attributes and span status #6951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dmathieu
wants to merge
6
commits into
open-telemetry:main
Choose a base branch
from
dmathieu:otelrestful-remove-semconvutil
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
otelrestful: use semconv package for request attributes and span status #6951
dmathieu
wants to merge
6
commits into
open-telemetry:main
from
dmathieu:otelrestful-remove-semconvutil
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6951 +/- ##
=====================================
Coverage 80.7% 80.7%
=====================================
Files 205 205
Lines 18083 18083
=====================================
+ Hits 14601 14604 +3
+ Misses 3062 3058 -4
- Partials 420 421 +1
🚀 New features to boost your workflow:
|
pellared
approved these changes
Mar 25, 2025
01c38ca
to
29e24fc
Compare
cc @XSAM for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We missed this use of semconvutil which we need to remove to be able to finalize the semconv migration.
I chose not to add a changelog entry here because there is technically no visible change, since the default is still to use the old semantic conventions only.