Skip to content

otelrestful: use semconv package for request attributes and span status #6951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

dmathieu
Copy link
Member

We missed this use of semconvutil which we need to remove to be able to finalize the semconv migration.

I chose not to add a changelog entry here because there is technically no visible change, since the default is still to use the old semantic conventions only.

@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Mar 18, 2025
@github-actions github-actions bot requested a review from dashpole March 18, 2025 08:25
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.7%. Comparing base (a50074d) to head (b15c691).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6951   +/-   ##
=====================================
  Coverage   80.7%   80.7%           
=====================================
  Files        205     205           
  Lines      18083   18083           
=====================================
+ Hits       14601   14604    +3     
+ Misses      3062    3058    -4     
- Partials     420     421    +1     
Files with missing lines Coverage Δ
...hub.com/emicklei/go-restful/otelrestful/restful.go 100.0% <100.0%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmathieu dmathieu marked this pull request as ready for review March 18, 2025 08:32
@dmathieu dmathieu requested a review from a team as a code owner March 18, 2025 08:32
@dmathieu dmathieu requested a review from XSAM March 26, 2025 10:03
@dmathieu dmathieu force-pushed the otelrestful-remove-semconvutil branch from 01c38ca to 29e24fc Compare March 26, 2025 10:41
@dmathieu
Copy link
Member Author

dmathieu commented Apr 9, 2025

cc @XSAM for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants