Rewrite verify_readmes.sh script in Go #6598
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eliott Bouhana <[email protected]>
eliottness
requested review from
MrAlias,
XSAM,
dashpole,
pellared and
dmathieu
as code owners
dmathieu
approved these changes
Apr 4, 2025
pellared
reviewed
Apr 8, 2025
MrAlias
approved these changes
Apr 8, 2025
|
@eliottness, are you able to address my comments? |
Signed-off-by: Eliott Bouhana <[email protected]>
pellared
reviewed
Apr 11, 2025
… comment) Signed-off-by: Eliott Bouhana <[email protected]>
pellared
approved these changes
Apr 11, 2025
| readme := filepath.Join(filepath.Dir(path), readmeFilename) | ||
| _, err = os.Stat(readme) | ||
| if os.IsNotExist(err) { | ||
| err = fmt.Errorf("couldn't find README.md for %q", filepath.Dir(path)) |
There was a problem hiding this comment.
Suggested change
| err = fmt.Errorf("couldn't find README.md for %q", filepath.Dir(path)) | |
| err = fmt.Errorf("couldn't find %s for %q", readmeFilename, filepath.Dir(path)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verify_readmes.shas the packageinternal/tools/verifyreadmesMakefileto call the new script instead of the old oneverify_readmes.shCloses #6527