Skip to content

refactor(tornado): replaces SpanAttributes by semconv attributes #3582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2025

Conversation

f-kanari
Copy link
Contributor

Description

Replaces usage of SpanAttributes with opentelemetry.semconv._incubating.attributes.http_attributes and opentelemetry.semconv._incubating.attributes.net_attributes

Refs #3475

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Copy link

linux-foundation-easycla bot commented Jun 13, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: f-kanari / name: f-kanari-safie (243a65a, 7667c35)
  • ✅ login: xrmx / name: Riccardo Magliocchetti (c368805)

@github-actions github-actions bot requested a review from shalevr June 13, 2025 08:04
@f-kanari f-kanari marked this pull request as draft June 13, 2025 08:10
@f-kanari f-kanari marked this pull request as ready for review June 13, 2025 08:59
@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 13, 2025
@xrmx xrmx enabled auto-merge (squash) June 16, 2025 12:06
@xrmx xrmx merged commit 0a03c9a into open-telemetry:main Jun 16, 2025
625 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants