Use ValueMap for Gauge - Throughput increased around 8x #2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2017 +/- ##
=====================================
Coverage 75.2% 75.2%
=====================================
Files 122 122
Lines 20874 20873 -1
=====================================
+ Hits 15698 15703 +5
+ Misses 5176 5170 -6 ☔ View full report in Codecov by Sentry. |
cijothomas
reviewed
Aug 13, 2024
| pub(crate) struct LastValue<T> { | ||
| values: Mutex<HashMap<AttributeSet, DataPointValue<T>>>, | ||
| pub(crate) struct LastValue<T: Number<T>> { | ||
| value_map: ValueMap<T, Assign>, |
There was a problem hiding this comment.
as important as the perf gains is the code reusability now! Hopefully, we can make it to Histograms too and have a single place dealing with the 1st half of the Metric aggregation problem, which is finding the datapoint to make updates to, and that is independent of actual aggregation!
cijothomas
approved these changes
Aug 13, 2024
|
Merging quickly as this is internal implementation fixes and follows existing approach from other instruments. We have good (not great) test coverage too now. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2012
Similar to #1833 and #1989 from @cijothomas
Related to #1740
Changes
Gaugeto useValueMapMachine information
OS: Ubuntu 22.04.3 LTS (5.15.146.1-microsoft-standard-WSL2) Hardware: AMD EPYC 7763 64-Core Processor - 2.44 GHz, 16vCPUs, RAM: 64.0 GBBenchmarks
There is a ~63% increase in benchmark performance. This is coming from
ValueMap's optimized lookup on the hot path.Stress Test
That's an improvement of nearly 8x for throughput. This is coming from
ValueMap's reduced thread contention and optimized lookup on the hot path.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes