refactor: change Protocol's Serialize and Deserialize to use standard values
#2765
+26
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
davidhewitt
force-pushed
the
protocol-serialize
branch
from
ea44667 to
3d2146d
Compare
…andard values BREAKING CHANGE: users depending on the previous values (or having saved them) may observe the change
davidhewitt
force-pushed
the
protocol-serialize
branch
from
3d2146d to
5aaf22c
Compare
davidhewitt
changed the title
Protocol's Serialize and Deserialize to use standard valuesProtocol's Serialize and Deserialize to use standard values
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2765 +/- ##
=====================================
Coverage 79.6% 79.6%
=====================================
Files 123 123
Lines 23034 23044 +10
=====================================
+ Hits 18356 18366 +10
Misses 4678 4678 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #2758
Changes
As noted in the above PR, the current implementation of
SerializeandDeserializefor protocol will emit the enum name as it is read in source code. I propose it would be better to match the standard values in the spec, especially if #2758 is merged.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes