-
Notifications
You must be signed in to change notification settings - Fork 513
fix: Processor now gets passed in reference #2726 #2895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2895 +/- ##
=====================================
Coverage 81.3% 81.3%
=====================================
Files 126 126
Lines 24254 24259 +5
=====================================
+ Hits 19736 19745 +9
+ Misses 4518 4514 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@Puffy1215 Could you clear the EasyCLA check? The bot comment should have all instructions. You'd probably want to consult your employer if contributing on behalf. (This is a one time requirement, before we can accept contributions) |
Fixes #2726
Changes
See #2726. Previous implementation was not up to spec. I replaced the
on_end()
trait function parameter with a&mut
reference toSpanData
, and refactored from there. Cloning still happens insideBatchSpanProcessor
where necessary. If there are any unnecessary clones that are still happening that I can fix, please let me know.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes