Skip to content

fix: Processor now gets passed in reference #2726 #2895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Puffy1215
Copy link

Fixes #2726

Changes

See #2726. Previous implementation was not up to spec. I replaced the on_end() trait function parameter with a &mut reference to SpanData, and refactored from there. Cloning still happens inside BatchSpanProcessor where necessary. If there are any unnecessary clones that are still happening that I can fix, please let me know.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@Puffy1215 Puffy1215 requested a review from a team as a code owner April 2, 2025 14:00
Copy link

linux-foundation-easycla bot commented Apr 2, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 98.21429% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.3%. Comparing base (10cf02c) to head (4df8134).

Files with missing lines Patch % Lines
opentelemetry-sdk/src/trace/span.rs 93.7% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2895   +/-   ##
=====================================
  Coverage   81.3%   81.3%           
=====================================
  Files        126     126           
  Lines      24254   24259    +5     
=====================================
+ Hits       19736   19745    +9     
+ Misses      4518    4514    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Puffy1215 Puffy1215 changed the title #2726 Processor now gets passed in reference fix: Processor now gets passed in reference #2726 Apr 2, 2025
@cijothomas
Copy link
Member

@Puffy1215 Could you clear the EasyCLA check? The bot comment should have all instructions. You'd probably want to consult your employer if contributing on behalf. (This is a one time requirement, before we can accept contributions)
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracing SDK - Processors get clone of SpanData which is incorrect
3 participants