OAUTH_UPDATE_PICTURE_ON_LOGIN documentation
#533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @kaytwo Can you add two more infos to this PR please? -> OAUTH_PICTURE_CLAIM must NOT be an empty string when you wanna use OAUTH_UPDATE_PICTURE_ON_LOGIN Otherwise, if OAUTH_PICTURE_CLAIM is set to an empty string, the profile picture for all users will always be this default person icon Please add this to your docs of OAUTH_UPDATE_PICTURE_ON_LOGIN as a " - Note: ...." And if you want, please also add to the OAUTH_PICTURE_CLAIM docs, that setting OAUTH_PICTURE_CLAIM to an empty string "" has this behaviour (of always using the default profile icon logo for everyone) 🙏 |
|
Super! Thanks :) Makes the docs 1% better by mentioning dependencies between env vars |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature landed in dev, presumably slated for v0.6.8 release.