Skip to content

remove hardcoded model parameter and make it configurable #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove hardcoded model parameter and make it configurable #108

wants to merge 1 commit into from

Conversation

ValorLin
Copy link

fix: remove hardcoded model parameter and make it configurable

  • Replace hardcoded model strings with the defaultModel value
  • Modify RealtimeClient connect method to pass model parameter to RealtimeAPI
  • Add defaultModel property to RealtimeAPI class
  • Add test case for connecting with a specific model

Fix #89

@mhjacobson
Copy link

Thanks for the patch! It fixed the bug for me, and I recommend they take it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Model gpt-4o-realtime-preview-2024-10-01 should not be hardcoded
3 participants
@ValorLin @mhjacobson @valor-lin