-
Notifications
You must be signed in to change notification settings - Fork 250
build: add start:with-theme command #1633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @KristinAoki! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
@openedx/committers-frontend-app-learning this PR is ready for review. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1633 +/- ##
=======================================
Coverage 90.09% 90.09%
=======================================
Files 338 338
Lines 5784 5784
Branches 1410 1410
=======================================
Hits 5211 5211
- Misses 556 557 +1
+ Partials 17 16 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@KristinAoki Can you rebase the PR, this seems to have a bunch of unrelated changes :) |
c5f6aef
to
ddf8b50
Compare
ddf8b50
to
837c488
Compare
@farhaanbukhsh removed unrelated changes |
@farhaanbukhsh Friendly nudge about reviewing this PR :) |
Hey @farhaanbukhsh, when do you think you'll get around to reviewing this PR? |
Description
This changes fixes the ability to change the css theme when running the code locally. Previously the theme could be overridden via
module.config.js
, but at some point this option stopped working. Without runningnpm run start:with-theme
there is no way to change the theme from the default openedX theme.