Skip to content

build: add start:with-theme command #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KristinAoki
Copy link
Member

Description

This changes fixes the ability to change the css theme when running the code locally. Previously the theme could be overridden via module.config.js, but at some point this option stopped working. Without running npm run start:with-theme there is no way to change the theme from the default openedX theme.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 11, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @KristinAoki!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Mar 11, 2025
@KristinAoki KristinAoki changed the title feat: add start:with-theme command build: add start:with-theme command Mar 11, 2025
@KristinAoki
Copy link
Member Author

@openedx/committers-frontend-app-learning this PR is ready for review.

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.09%. Comparing base (81b6211) to head (837c488).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1633   +/-   ##
=======================================
  Coverage   90.09%   90.09%           
=======================================
  Files         338      338           
  Lines        5784     5784           
  Branches     1410     1410           
=======================================
  Hits         5211     5211           
- Misses        556      557    +1     
+ Partials       17       16    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Mar 14, 2025
@itsjeyd itsjeyd moved this from Needs Triage to Ready for Review in Contributions Mar 14, 2025
@itsjeyd itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Mar 14, 2025
@itsjeyd itsjeyd requested a review from a team March 14, 2025 08:39
@farhaanbukhsh
Copy link
Member

@KristinAoki Can you rebase the PR, this seems to have a bunch of unrelated changes :)

@KristinAoki KristinAoki force-pushed the KristinAoki/add-start-with-theme-command branch from c5f6aef to ddf8b50 Compare March 26, 2025 14:10
@KristinAoki KristinAoki force-pushed the KristinAoki/add-start-with-theme-command branch from ddf8b50 to 837c488 Compare March 26, 2025 14:11
@KristinAoki
Copy link
Member Author

@farhaanbukhsh removed unrelated changes

@itsjeyd itsjeyd moved this from Ready for Review to In Eng Review in Contributions Apr 1, 2025
@itsjeyd
Copy link

itsjeyd commented Apr 10, 2025

@farhaanbukhsh Friendly nudge about reviewing this PR :)

@itsjeyd
Copy link

itsjeyd commented May 8, 2025

Hey @farhaanbukhsh, when do you think you'll get around to reviewing this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Status: In Eng Review
Development

Successfully merging this pull request may close these issues.

4 participants