-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8303762: Optimize vector slice operation with constant index using VPALIGNR instruction #24104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ALIGNR instruction
👋 Welcome back jbhateja! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@jatin-bhateja The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
/label add hotspot-compiler-dev |
@jatin-bhateja |
@jatin-bhateja This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a |
/keepalive |
@jatin-bhateja The pull request is being re-evaluated and the inactivity timeout has been reset. |
@jatin-bhateja this pull request can not be integrated into git checkout JDK-8303762
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
Patch optimizes Vector. slice operation with constant index using x86 ALIGNR instruction.
It also adds a new hybrid call generator to facilitate lazy intrinsification or else perform procedural inlining to circumvent call overhead and boxing penalties in case fallback implementation expect to operate over vectors. Existing vector API-based slice implementation is now the fallback code that gets inlined in case intrinsification fails.
Preliminary performance results show 1.5 to 2x gain over existing implementation.
[TBD] Limit inlining to cases where fallback code operate over vectors.
Vector API jtreg tests pass at different AVX levels.
Please share your feedback.
Best Regards,
Jatin
Progress
Warnings
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24104/head:pull/24104
$ git checkout pull/24104
Update a local copy of the PR:
$ git checkout pull/24104
$ git pull https://git.openjdk.org/jdk.git pull/24104/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24104
View PR using the GUI difftool:
$ git pr show -t 24104
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24104.diff